Update solo/atmos_model.F90 for FMS module new aliasing #25
Conversation
…he FMS 2023.02 release
laurenchilutti
requested review from
bensonr and
mcallic2
and removed request for
thomas-robinson
|
|
||
|
|
||
| !----- read namelist ------- | ||
|
|
||
| read (input_nml_file, nml=main_nml, iostat=io) | ||
| read (fms_mpp_input_nml_file, nml=main_nml, iostat=io) | ||
| ierr = check_nml_error(io, 'main_nml') |
There was a problem hiding this comment.
Did we change check_nml_error as well?
There was a problem hiding this comment.
No, this was not aliased in libFMS.F90
| call write_version_number ("program atmos_model", version) | ||
| if ( mpp_pe() == mpp_root_pe() ) write (logunit, nml=main_nml) | ||
| call fms_write_version_number ("program atmos_model", version) | ||
| if ( fms_mpp_pe() == fms_mpp_root_pe() ) write (logunit, nml=main_nml) | ||
|
|
||
| if (dt_atmos == 0) then | ||
| call error_mesg ('program atmos_model', 'dt_atmos has not been specified', FATAL) |
There was a problem hiding this comment.
Did we change error_mesg as well?
There was a problem hiding this comment.
No, this also wasnt changed.
There was a problem hiding this comment.
You can see there are a few that were unchanged. https://github.com/NOAA-GFDL/FMS/blob/2be8aa452ad3e5f43e92c38a64f12d1ae6c43fb8/libFMS.F90#L400-L401
There was a problem hiding this comment.
Let's put an issue in to start the discussion for these few that were left unchanged in the FMS modulefile. I'll go on ahead and approve for now.
|
I will merge this now and create a 2023.02-beta1 tag for testing. I have created an issue to bring attention to the tow routines that were not aliased. And if there are more changes in FMS, then I will create another PR to address that. |
Description
solo/atmos_model.F90 uses the FMS module. In FMS 2023.02-beta1 this module has aliased all functions to contain a prefix before the function name. This PR changes to the new naming convention so that the code can compile with FMS 2023.02-beta2.
Fixes # (issue)
How Has This Been Tested?
Tested with SHiELD solo tests on Gaea with intel
Checklist: