26 escape.git.version.string #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gfortran on Mac OS X does not add the __APPLE__ macro. Updated the two Mac OS X templates to add this macro definition to the the Fortran preprocessor flags.
Update the `-g` option to escape the double quote (`"`) in `mkmf` around the call to `git-version-string`. This is to resolve the quote expansion of certain MPI compiler wrappers.
The test for the git version string needed to be updated to match the update in mkmf to escape the string.
ceblanton
pushed a commit
to ceblanton/mkmf
that referenced
this pull request
Feb 7, 2020
This reverts commit 1a60b1a. Revert the update to `mkmf -g` option that escaped the double quotes around the call to `git-version-string`. The reason is that this update causes some compiler wrappers to have quoting problems (NOAA-GFDL#33) that resulted in `git-version-string`'s output not being quoted as needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Escape the quotes in the call to
git-version-stringinmkmf.Update
mkmfversion number.fixes #26.