Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource config script for missing directory #634

Merged
merged 1 commit into from
May 28, 2024

Conversation

robertbartel
Copy link
Contributor

Updating create_resources_config.sh helper script to account for missing parent directory for the to-be-created resource.yaml and create that directory when needed, or bail if the path is an existing non-directory.

Closes #626.

Updating create_resources_config.sh helper script to account for missing
parent directory for the to-be-created resource.yaml and create that
directory when needed, or bail if the path is an existing non-directory.
@robertbartel robertbartel added bug Something isn't working maas MaaS Workstream labels May 28, 2024
@robertbartel robertbartel requested a review from aaraney May 28, 2024 14:31
Copy link
Member

@aaraney aaraney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks, @robertbartel!

@aaraney aaraney merged commit 2670cb6 into NOAA-OWP:master May 28, 2024
4 of 8 checks passed
@robertbartel robertbartel deleted the bug/fix_626/main branch May 28, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maas MaaS Workstream
Projects
None yet
2 participants