Implement standard definitions of Set_value & Set_value_at_indices

[madMatchstick]

Adjusts two BMI functions,

1. Set_value()
2. Set_value_at_indices()

to "standard" BMI definitions according to examples and readme documents

3. Also - minor is_aet_rootzone (boolean flag) name updates left over from PR bug_fix_aet rootzone #105

Changes

• bmi_c.c

Testing

1. NextGen Integration Workflow in parent repo passes; this checks ngen build/run coupling cfe & pet
2. Standalone and BMI unit testing workflow (yml here)
3. NextGen Realization in SoilFreezeThaw; coupling cfe, sft, smp & pet
4. Config sets both is_sft_coupled & is_aet_rootzone to true. e.g.,

is_sft_coupled=true
ice_content_threshold=0.15
is_aet_rootzone=true
soil_layer_depths=0.1,0.4,1.0,2.0
max_rootzone_layer=2

as outlined in configs/readme here & here.

Notes

• Closes Issue Adjust implementations of set_value and set_value_at_indices to more closely follow BMI standard #93

Checklist

• PR has an informative and human-readable title
• Changes are limited to a single goal (no scope creep)
• Code can be automatically merged (no conflicts)
• Code follows project standards (link if applicable)
• Passes all existing automated tests
• Any change in functionality is tested
• New functions are documented (with a description, list of inputs, and expected output)
• Placeholder code is flagged / future todos are captured in comments
• Visually tested in supported browsers and devices (see checklist below 👇)
• Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
• Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

• Windows
• Linux
• Browser

[ajkhattak]

this only works for doubles and not for array of doubles, so it will potentially break the coupling with soil_moisture_profile which is used in rootzone-based AET.

[ajkhattak]

@madMatchstick while reviewing and testing this PR, which breaks the coupling with SMP, I found a bug in the rootzone-based AET (not directly related to this PR). so I think that PR (104) should be merged before this one, as we need to ensure that Set_value and Set_valued_at_indices work properly for rootzone-based AET.

[madMatchstick]

@madMatchstick while reviewing and testing this PR, which breaks the coupling with SMP, I found a bug in the rootzone-based AET (not directly related to this PR). so I think that PR (104) should be merged before this one, as we need to ensure that Set_value and Set_valued_at_indices work properly for rootzone-based AET.

Ok, thanks Ahmad - looking at the PR you linked, I now understand what you mean by "breaks when coupling with SMP" as the aet_rootzone flag was always OFF. I'll merge that one first and go from there....

[ajkhattak]

sounds good.. we have to make sure that get_var_nbytes returns the correct nbytes for the soil_moisture_profile.

[ajkhattak]

@madMatchstick should we close this??