pre-CFE2.0_PR

[ajkhattak]

This PR is based on PR #116 and the current master. It wraps up the full capability of Nash Cascade-based surface runoff with backward compatibility. An example config and realization files are provided to turn ON Nash_Cascade surface runoff scheme. The old scheme GIUH-based surface runoff has been retained, and is the default option.

Based on the discussion with Fred, the commit 6d08db7bec2ec6cc2cc2446300c9e0d2076e0fc7 should be tagged as CFE1.0, and the new version will be CFE2.0 (previously we were mistakenly calling it CFE3.0)

NOTE: CFE2.0 defaults to CFE1.0.

Additions

• Added runon infiltration, retention depth, and calibratable parameters in addition to changes in PR variable_names_changes #116

Removals

• None

Changes

• see PR variable_names_changes #116

Testing

1. All existing tests have been tested, and old and new results are identical.
2. All configuration files have been tested to work on both CFE1.0 and CFE2.0

Checklist

• PR has an informative and human-readable title
• Changes are limited to a single goal (no scope creep)
• Code can be automatically merged (no conflicts)
• Code follows project standards (link if applicable)
• Passes all existing automated tests
• Any change in functionality is tested
• New functions are documented (with a description, list of inputs, and expected output)
• Reviewers requested with the Reviewers tool ➡️

[madMatchstick]

@ajkhattak - I was able to run the new realization_cfe_pet_surfnash_calib.json after typeo fix - thanks! Although I did not look into results just yet.

Noting that the ngen integration tests use the existing giuh default option; realization_cfe_pet_surfgiuh.json - just a file name change for clarity.

[ajkhattak]

@madMatchstick realization_cfe_pet_surfnash_calib.json will be added to CI, along with a few other minor changes, once this PR is done.
To compare the results of cfe1.0 vs this PR, I would use our four tests, if those results look okay, we are good.

[madMatchstick]

@ajkhattak - Very minor recommended changes:

1. Install.md - go ahead and include the correct cfe lib path based on realizations, CI, etc. So,

cmake -B extern/cfe/cfe/cmake_build -S extern/cfe/cfe/ -DNGEN=ON
make -C extern/cfe/cfe/cmake_build

2. Question - why are we building fortran bmi for this example? We aren't coupling with NOM? Also not seeing instructions for PET lib build? Little confused here...
3. Probably best to change "model_type_name": "bmi_multi_noahowp_cfe" to something like "bmi_multi_cfe_pet" for good measure. Here & here.
4. Update bmi unit test to include 18th param K_infiltration newly added.

-Thanks!

[madMatchstick]

@ajkhattak - Thanks for the recent commits. I do not see any major problems with this PR. We should probably start using releases for code versioning?