Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close initialization file after reading to avoid resource leak #68

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

hellkite500
Copy link
Member

The bmi initialization code leaks the file handle from the fopen call. Especially in the ngen case where this be initialized many times, this leads to an exhaustion of open file handles on the system can cause it to crash. Fixes #67.

Changes

  • Close the file handle after reading of file is complete

Testing

  1. Tested with ngen

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@SnowHydrology SnowHydrology self-assigned this Oct 25, 2022
@SnowHydrology SnowHydrology merged commit 58fa6b3 into NOAA-OWP:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BMI Initialize leaks file handle
2 participants