Add VIIRS SCF processing capability and merge with current IMS_proc #7
Conversation
|
Please review: @ClaraDraper-NOAA, @YoulongXia-NOAA, @tsga Thank you! |
| RES=384 | ||
|
|
||
| EXEC_DIR=../exec/bin/ | ||
| RESTART_DIR=/scratch2/NCEPDEV/stmp1/Yuan.Xue/pull_request/restart_files/ |
There was a problem hiding this comment.
The best way do not link your personal directory. Please consult with Clara to put them in land/DA/IMS or VIRRS directory.
There was a problem hiding this comment.
This is for the test case restart files. For IMS, Clara linked to her own directory. For VIIRS, for now, I put them in my own stmp directory. Later, we can put these restart files for both test cases together.
| namelist/fSCF_nml/ idim, jdim, source, otype, yyyymmddhh, jdate, fcst_path, lsm, skip_SD, & !required input | ||
| IMS_obs_path, IMS_ind_path, imsformat, imsversion, imsres, & !(optional) input needed for IMS DA | ||
| VIIRS_obs_path, VIIRS_ind_path, viirsversion, viirs_threshold !(optional) input needed for VIIRS DA | ||
|
|
There was a problem hiding this comment.
Although you used the same fscf.nml, but actually you put different contents. To make an identification, how to about still using fims.nml and fviirs.nml. Here namelist you can use two namelists. Although there are some redundancy, but it is clear. See If Clara has different opinion
There was a problem hiding this comment.
Thanks for your comments. Per discussions with Clara in June, it is more preferred having only ONE namelist for both cases. Hence, I merged fims.nml and fviirs.nml as fSCF.nml. Hence, I will leave it as fSCF.nml.
There was a problem hiding this comment.
If you do so, you should use single submit job including all input into single nml file. Otherwise, it is confusing the users.
There was a problem hiding this comment.
This is the reason you can consult with Clara. If it pushes to github, it should not use your personal directory based on my work experience with Mike for land-data-utils.
There was a problem hiding this comment.
Leave the namelist as is for now per discussions with Clara on 08/08/2024.
Describe your changes (READY FOR REVIEW/DO NOT MERGE!)
Summarise all code changes included in PR:
1.added VIIRS processing unit;
2.merged VIIRS processing unit with IMS processing one;
3.added VIIRS super-ob percentage threshold as a parameter in the namelist file;
4.added a new VIIRS test case, and separated from previous IMS test cases.
List any associated PRs in the submodules.
This is the PR for the submodule land-SCF_proc.
Issue ticket number and link
List the git Issue that this PR addresses:
#6
Test output
Is this PR expected to pass the DA_IMS_test (ie., does it change the output)?
Yes.
Does it pass the DA_IMS_test?
Yes, it passed the IMS processing test case for both .nc and .ascii formatted.
If changes to the test results are expected, what are these changes? Provide a link to the output directory when running the test:
The new benchmark output for VIIRS can be found on Hera at: /scratch2/NCEPDEV/stmp1/Yuan.Xue/pull_request/land-SCF_proc/test/VIIRSscf.20160501.C384.mx025_oro_data.nc
Checklist before requesting a review