Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change splash screen from homebrew to "Licensed by Nintendo" #2

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

Zachary-Rude
Copy link
Collaborator

This would make it feel more like a real 3DS game. I chose Licensed instead of Nintendo because then it would be more obvious that it is a 3rd party game.

@Zachary-Rude
Copy link
Collaborator Author

Also, I saw that -lcurl was in the ld parameters in the Makefile, which was causing the build to fail every time, so I'm trying to fix that as well.

@tobid7
Copy link
Member

tobid7 commented Oct 10, 2023

Ah lol yea interesting idea hopefully curl is not required by RenderD7 lol ill take a look on the request later

@tobid7
Copy link
Member

tobid7 commented Oct 10, 2023

Ah lol not required yet (lcurl) so i test and merge later

@tobid7
Copy link
Member

tobid7 commented Oct 10, 2023

Okay so update: The Licensed is a nice idea
And for the -lcurl you may not have portlibs installed or another error as in my systems it builds sucess but ill let it get removed as it is not required by Flappy Bird or RenderD7

Oh and i could add you to Credits if you want

@tobid7
Copy link
Member

tobid7 commented Oct 10, 2023

As the current debug build of the workflow doesnt work caused by RenderD7 :( ive created a temp patched version cause dont want to leak rd7-0.9.5 which fixes the mINI::Parser error by commenting out

@Zachary-Rude
Copy link
Collaborator Author

sure! please add me to the credits!

@Zachary-Rude
Copy link
Collaborator Author

it still thinks lcurl doesnt exist, im on windows btw

@tobid7
Copy link
Member

tobid7 commented Oct 18, 2023

Hmmm may be you didn't run "pacman -Syu 3ds-portlibs" xd but yeah setting up dkp on windows is pain

@Zachary-Rude
Copy link
Collaborator Author

i ran that command, but it still doesnt work
and when i remove -lcurl from the makefile, it builds successfully, but when i try to launch it on my 3ds, it just crashes after the render d7 splash screen

@tobid7
Copy link
Member

tobid7 commented Oct 20, 2023

yeah ik I think you need to grab my latest commit as there is a problem with the config in renderd7 0.9.4 (again) xd may be the latest works (for me) as ive removed the config entirely

use patched rd7 to 'fix' rd7-cfg ini failure
@tobid7
Copy link
Member

tobid7 commented Oct 21, 2023

hmm still seeing the homebrew logo but it works with the licensed if '-logo "../app/logo.lz11"' gets removed from the Makefile in line 256

@Zachary-Rude
Copy link
Collaborator Author

hmm still seeing the homebrew logo but it works with the licensed if '-logo "../app/logo.lz11"' gets removed from the Makefile in line 256

i'll try that! i'll post an update once i build the cia file on my end! oh, and also, i updated the icon for the game so that it is perfectly square, as opposed to being rounded with a white background

@Zachary-Rude
Copy link
Collaborator Author

ok, so i tested it, and removing -logo "../app/logo.lz11" does indeed make the licensed logo work! now, i'll push some commits involving the fixed icon and the fixed Makefile!

@tobid7
Copy link
Member

tobid7 commented Nov 1, 2023

Before creating a release i'll verify that the patched RenderD7 doesn't make problems... And i recommend to put makerom and bannertool into devkitpro/tools/bin xd

@tobid7 tobid7 merged commit 5a741e8 into NPI-D7:master Nov 1, 2023
2 checks passed
@Zachary-Rude
Copy link
Collaborator Author

Zachary-Rude commented Nov 2, 2023

would you please give me write access to this repo?

@tobid7
Copy link
Member

tobid7 commented Nov 2, 2023

Hmmm i could but dont d3stroy the codebase xd

@tobid7
Copy link
Member

tobid7 commented Nov 2, 2023

Hmmm i could but dont d3stroy the codebase xd

-Update github should send you an invite mail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants