Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unique and fixed GCF identifier in scoring #103

Closed
CunliangGeng opened this issue Feb 15, 2023 · 0 comments · Fixed by #142
Closed

Use unique and fixed GCF identifier in scoring #103

CunliangGeng opened this issue Feb 15, 2023 · 0 comments · Fixed by #142
Labels
GEN genomics related issues scoring issues related to scoring part

Comments

@CunliangGeng
Copy link
Member

The gcf.id is an index of the GCF object within a list of GCFs and will change when the list changes. gcf.id is used in scoring part (data_linking.py and link_finder.py).

It's better to replace gcf.id(int) with the unique and fixed gcf.gcf_id (string). And so, the logics of scoring part will have to be updated.
@CunliangGeng CunliangGeng added GEN genomics related issues scoring issues related to scoring part labels Feb 15, 2023
CunliangGeng added a commit that referenced this issue Feb 15, 2023
@CunliangGeng
add attribute id to GCF class and use gcf.id in scoring
2fd2b2b 
This is a temporary solution, will remove it later. See issue 103 #103.
@CunliangGeng CunliangGeng mentioned this issue Feb 15, 2023
Merged
CunliangGeng added a commit that referenced this issue Feb 23, 2023
@CunliangGeng
Fix local test error (#105)
cf8a5f4 
This is a temporary solution. Loading of strains will be refactored later. See issue 104.

* add attribute id to GCF class and use gcf.id in scoring

This is a temporary solution, will remove it later. See issue 103 #103.
@CunliangGeng CunliangGeng linked a pull request May 12, 2023 that will close this issue
Use unique string IDs #142
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GEN genomics related issues scoring issues related to scoring part
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use unique string IDs NPLinker/nplinker
1 participant
@CunliangGeng