Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstraction of run_bigscape function #115

Closed
1 of 2 tasks
CunliangGeng opened this issue Feb 23, 2023 · 1 comment
Closed
1 of 2 tasks

Abstraction of run_bigscape function #115

CunliangGeng opened this issue Feb 23, 2023 · 1 comment
Assignees
Labels
GEN genomics related issues

Comments

@CunliangGeng
Copy link
Member

CunliangGeng commented Feb 23, 2023

Refactor run_bigscape function:

  • explore if it is necessary to refactor the function to a class that follows a base class Runner (non exist yet)
  • Since the download and run logics should be independent, we should move run_bigscape out of PODPDownloader to an higher level, for example to the loader.py module.
    • Right now run_biscape is defined in pairedomics/runbigscape.py, and it's used in podp_run_bigscape, called in pairedomics/downloader.py.
@CunliangGeng CunliangGeng added the GEN genomics related issues label Feb 23, 2023
@CunliangGeng CunliangGeng added this to the refactor codebase milestone Feb 23, 2023
@CunliangGeng CunliangGeng self-assigned this Feb 27, 2024
@CunliangGeng
Copy link
Member Author

We will keep it as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GEN genomics related issues
Projects
Status: Done
Development

No branches or pull requests

1 participant