Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DatasetLoader class #145

Closed
1 task
Tracked by #147
gcroci2 opened this issue Jun 21, 2023 · 1 comment
Closed
1 task
Tracked by #147

Refactor DatasetLoader class #145

gcroci2 opened this issue Jun 21, 2023 · 1 comment

Comments

@gcroci2
Copy link
Contributor

gcroci2 commented Jun 21, 2023

We will more tasks in this issue in the near future.

  • Since the download and run logics should be independent, we should move run_bigscape out of PODPDownloader to an higher level, for example to the loader.py module.
    • Right now run_biscape is defined in pairedomics/runbigscape.py, and it's used in podp_run_bigscape, called in pairedomics/downloader.py.
@gcroci2 gcroci2 mentioned this issue Jun 21, 2023
Merged
This was referenced Jun 27, 2023
Closed
Closed
@CunliangGeng
Copy link
Member

Merge this issue to #115.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CunliangGeng @gcroci2