-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Bigscape v2 data #234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the support of bigscape v2!
I left some minor comments for you.
One final comment on all files is that please remember to format all files using ruff
. If you are also using vscode, the formatting could be automatic, see the guide.
Just merged a PR to ignore docstrings for test files. So it's ok to not have docstrings for test functions. I'm off from now, @gcroci2 could take over this PR. |
Sure! @adraismawur just ask for my review again when you'll have integrated Cunliang's one :) |
Alright! Changes were committed. Could you review this again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good :) Thanks for the contribution!
The action for checking the format needs to pass before merging. Please run ruff as explained here and then commit the format/linting fixes.
Co-authored-by: Giulia Crocioni <55382553+gcroci2@users.noreply.github.com>
Ok I have run the formatter, but there are files outside of those I edited in this PR that fail using ruff. Should I rebase dev onto this branch and add formatting changes of other files to this one, or should I just merge as-is and the formatting can be done elsewhere? |
I still see: About the linting check failing, is this expected? @CunliangGeng If yes, I think we should exclude the checking on such files on the CI, otherwise it can be confusing for contributors. |
Good point! I updated the github actions to only check changed files in PR #238. |
This PR enables the user to load data from a BiG-SCAPE V2 database file. The
data_sqlite.db
file is expected to be in the same place as themix_clustering_[cutoff].tsv
would otherwise be.If both files are found, the loader selects the tsv file.