fix mypy and ruff errors #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 11, 2024
Merged
Merged
|
It's ready for review. |
CunliangGeng
force-pushed
the
refactor_NPLinker_methods
branch
from
e9776df
to
ea42a68
Compare
CunliangGeng
force-pushed
the
fix_mypy_ruff_errors
branch
from
b11ce5e
to
7ed0c0a
Compare
gcroci2
reviewed
Jun 14, 2024
There was a problem hiding this comment.
In general, there are many lines touched by this PR where Mapping or Sequence are not used for type hints instead of dict and list. I started commenting on them, but since I realized they are quite a lot I wonder if there is a reason for this. Before I keep leaving many comments, better to know ;)
CunliangGeng
force-pushed
the
refactor_NPLinker_methods
branch
from
ea42a68
to
e7f0420
Compare
CunliangGeng
force-pushed
the
fix_mypy_ruff_errors
branch
from
7ed0c0a
to
36a474d
Compare
Merged
gcroci2
approved these changes
Jun 14, 2024
Merge activity
|
CunliangGeng
force-pushed
the
refactor_NPLinker_methods
branch
from
e7f0420
to
155f7f8
Compare
fix code or ignore type checking for some nonsense mypy errors
This ensures that the type hints are available both during type checking and at runtime, improving code clarity and reducing the chance of runtime errors related to type hints.
use broader type hints Sequence and Mapping to replace list and dict, respectively
use more general type when necessary
CunliangGeng
force-pushed
the
fix_mypy_ruff_errors
branch
from
621635a
to
4d54869
Compare
|
This was referenced Jun 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to solve all type hints errors (mypy), formatting errors (ruff) and typos for refactored code. As for non-refactored code, we keep it as it is.
As for type hints, the changes follow the rules below:
@overloadfor different data types of the same argumentSequenceandMappingto replacelistanddict, respectively, as much as possibleTYPE_CHECKINGto only avoid circular imports