Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improving type hints and usage of abc #259

Merged
merged 18 commits into from
Jun 20, 2024
Merged

improving type hints and usage of abc #259

merged 18 commits into from
Jun 20, 2024

Commits on Jun 17, 2024

  1. Configuration menu
    Copy the full SHA
    f1f0383 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    06034a8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6ca5020 View commit details
    Browse the repository at this point in the history
  4. fix bug in unit tests

    CunliangGeng committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    541d1ea View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    02b9521 View commit details
    Browse the repository at this point in the history
  6. add type alias

    CunliangGeng committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    3b8a2f9 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ccb0ead View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ee40a86 View commit details
    Browse the repository at this point in the history
  9. remove unused type var

    CunliangGeng committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    04e7ccd View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    68b8dc9 View commit details
    Browse the repository at this point in the history
  11. change registering to inheritance of abstract class

    Registering as virtual class can avoid metclass conflicts. However, it's not an issue we need to worry in this codebase, since all concrete classes, e.g. AntismashBGCLoader,   inherit only one base class instead of multiple classes that have different metaclasses.
    
    Using inheritance of abstract class is more straightforward and explict.
    CunliangGeng committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    d5e1faa View commit details
    Browse the repository at this point in the history
  12. simplify imports

    CunliangGeng committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    f023db9 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Configuration menu
    Copy the full SHA
    57aeacf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f8593b5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cdf838e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    297af33 View commit details
    Browse the repository at this point in the history
  5. fix bug of logger name

    CunliangGeng committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    afc2029 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c870931 View commit details
    Browse the repository at this point in the history