-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improving type hints and usage of abc #259
Merged
Merged
Commits on Jun 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f1f0383 - Browse repository at this point
Copy the full SHA f1f0383View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06034a8 - Browse repository at this point
Copy the full SHA 06034a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ca5020 - Browse repository at this point
Copy the full SHA 6ca5020View commit details -
Configuration menu - View commit details
-
Copy full SHA for 541d1ea - Browse repository at this point
Copy the full SHA 541d1eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 02b9521 - Browse repository at this point
Copy the full SHA 02b9521View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b8a2f9 - Browse repository at this point
Copy the full SHA 3b8a2f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ccb0ead - Browse repository at this point
Copy the full SHA ccb0eadView commit details -
Configuration menu - View commit details
-
Copy full SHA for ee40a86 - Browse repository at this point
Copy the full SHA ee40a86View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04e7ccd - Browse repository at this point
Copy the full SHA 04e7ccdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 68b8dc9 - Browse repository at this point
Copy the full SHA 68b8dc9View commit details -
change registering to inheritance of abstract class
Registering as virtual class can avoid metclass conflicts. However, it's not an issue we need to worry in this codebase, since all concrete classes, e.g. AntismashBGCLoader, inherit only one base class instead of multiple classes that have different metaclasses. Using inheritance of abstract class is more straightforward and explict.
Configuration menu - View commit details
-
Copy full SHA for d5e1faa - Browse repository at this point
Copy the full SHA d5e1faaView commit details -
Configuration menu - View commit details
-
Copy full SHA for f023db9 - Browse repository at this point
Copy the full SHA f023db9View commit details
Commits on Jun 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 57aeacf - Browse repository at this point
Copy the full SHA 57aeacfView commit details -
Configuration menu - View commit details
-
Copy full SHA for f8593b5 - Browse repository at this point
Copy the full SHA f8593b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for cdf838e - Browse repository at this point
Copy the full SHA cdf838eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 297af33 - Browse repository at this point
Copy the full SHA 297af33View commit details -
Configuration menu - View commit details
-
Copy full SHA for afc2029 - Browse repository at this point
Copy the full SHA afc2029View commit details -
Configuration menu - View commit details
-
Copy full SHA for c870931 - Browse repository at this point
Copy the full SHA c870931View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.