Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify error check in unit tests #263

Merged
merged 2 commits into from
Jul 6, 2024
Merged

Conversation

CunliangGeng
Copy link
Member

@CunliangGeng CunliangGeng commented Jul 4, 2024

To use the match of pytest.rasises(ValueError, match="...") to check the error message in unit tests, which simplifies the test code.

Copy link
Member Author

CunliangGeng commented Jul 4, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CunliangGeng and the rest of your teammates on Graphite Graphite

@CunliangGeng CunliangGeng requested a review from gcroci2 July 4, 2024 08:27
@CunliangGeng CunliangGeng self-assigned this Jul 4, 2024
@CunliangGeng CunliangGeng marked this pull request as ready for review July 4, 2024 08:27
Copy link
Member Author

CunliangGeng commented Jul 6, 2024

Merge activity

  • Jul 6, 5:45 AM EDT: @CunliangGeng started a stack merge that includes this pull request via Graphite.
  • Jul 6, 5:49 AM EDT: Graphite rebased this pull request as part of a merge.
  • Jul 6, 5:51 AM EDT: @CunliangGeng merged this pull request with Graphite.

@CunliangGeng CunliangGeng force-pushed the warn_failed_antismash_downloads branch from dffcbe3 to 8080748 Compare July 6, 2024 09:46
Base automatically changed from warn_failed_antismash_downloads to dev July 6, 2024 09:48
@CunliangGeng CunliangGeng merged commit 9897381 into dev Jul 6, 2024
1 of 3 checks passed
@CunliangGeng CunliangGeng deleted the match_error_in_tests branch July 6, 2024 09:51
Copy link

sonarcloud bot commented Jul 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants