Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update make.jl #384

Merged
merged 9 commits into from
Jul 2, 2024
Merged

Update make.jl #384

merged 9 commits into from
Jul 2, 2024

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Jun 26, 2024

No description provided.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.70%. Comparing base (86620ff) to head (14ee877).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #384   +/-   ##
=======================================
  Coverage   77.70%   77.70%           
=======================================
  Files          68       68           
  Lines        5287     5287           
=======================================
  Hits         4108     4108           
  Misses       1179     1179           
Flag Coverage Δ
unittests 77.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jd-lara jd-lara requested a review from daniel-thom July 1, 2024 23:00
@jd-lara
Copy link
Member Author

jd-lara commented Jul 1, 2024

@daniel-thom this fixes the docs failures and updates documenter to v1

@jd-lara
Copy link
Member Author

jd-lara commented Jul 1, 2024

@daniel-thom I opened this JuliaLang/Pkg.jl#3937

I can't understand how this issue happens or how to reproduce. We only see this in the IS documentation

@jd-lara
Copy link
Member Author

jd-lara commented Jul 1, 2024

@daniel-thom I opened this JuliaLang/Pkg.jl#3937

I can't understand how this issue happens or how to reproduce. We only see this in the IS documentation

In other news, I fixed this by making a change to use latest Julia for documentation instead of 1.6

@jd-lara
Copy link
Member Author

jd-lara commented Jul 1, 2024

While developing code and tests it can be convenient to run a subset of tests.
You can do this with a combination of TestEnv.jl and ReTest.jl.

**Note**: Per recommendations from the developers of TestEnv.jl, install the package
in your global julia environment. Do the same for Revise.jl.

```
$ julia
\$ julia
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the backslashes for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documenter throws an error if there are not escaped $ symbols

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted the change

@jd-lara jd-lara self-assigned this Jul 2, 2024
@jd-lara jd-lara added the documentation Improvements or additions to documentation label Jul 2, 2024
@jd-lara jd-lara merged commit fe01167 into main Jul 2, 2024
10 checks passed
@jd-lara jd-lara deleted the jd/restore_docs branch July 2, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants