Move ValueCurves, cost aliases, CostCurve, FuelCurve, and associated tests from PSY to IS (IS version)
#392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrielKS
commented
Aug 2, 2024
| @@ -2,6 +2,10 @@ isdefined(Base, :__precompile__) && __precompile__() | |||
|
|
|||
| module InfrastructureSystems | |||
|
|
|||
| # Cost aliases don't display properly unless they are exported from IS | |||
There was a problem hiding this comment.
@jd-lara you won't love this, but exporting the aliases is the only way to get them to register as aliases for the purposes of printing and such, and I think overriding the printing of these types is uglier than adding them as exports. @daniel-thom agrees that this is fairly harmless — a name collision is unlikely because these would be imported rather than redefined in any package that also exports them, and also we are (possibly accidentally) already exporting some things from IS.
jd-lara
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These features are now needed in packages that don't have a dependency on PowerSystems, so they need to be moved to InfrastructureSystems. The PRs are pretty straightforward, almost entirely just copypasting.