-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to Readme and Docs #267
Conversation
jordanperr
commented
Jan 29, 2024
- Add table of analysis methods with citations (placeholder for now)
- updated citation instructions
- add a warning box showing a disclaimer related to use
… citations, updated citation instructions, and a warning box showing a disclaimer related to use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice way to organize the readme. I added and reformatted some references, and added some suggested revisions to the text as comments. I still need to add some references for the wake loss and yaw misalignment methods, but will update those by the end of the week.
My only other comment is that we should also update the "About" section on GitHub when we merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together @jordanperr! This is a nice update to the project's README, and looking forward to getting it integrated into the docs site main page as well. I think I may have updated the docs main page for v3, though, so it might be worthwhile to crosscheck them and see if anything is worth salvaging from there prior to swapping it out with the README.
readme.md
Outdated
} | ||
| Name | Description | Citations | | ||
| --- | --- | --- | | ||
| ``MonteCarloAEP`` | This routine estimates the long-term annual energy production (AEP) of a wind power plant (typically over 10-20 years) based on operational data from a shorter period of record (e.g., 1-3 years), along with the uncertainty. | [^2], [^3] | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the PRUF publications describe the AEP analysis method, so we could also cite references 1 and 4 if you think that's appropriate here.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #267 +/- ##
===========================================
- Coverage 72.49% 72.49% -0.01%
===========================================
Files 29 29
Lines 3687 3690 +3
Branches 794 796 +2
===========================================
+ Hits 2673 2675 +2
- Misses 825 826 +1
Partials 189 189 ☔ View full report in Codecov by Sentry. |
…JOSS citation to references list.
…itions to end of readme.
@all-contributors |
File README.md was not found in the repository (NREL/OpenOA). |
@all-contributors |
File README.md was not found in the repository (NREL/OpenOA). |
@all-contributors |
File README.md was not found in the repository (NREL/OpenOA). |
sphinx/index.md
Outdated
@@ -0,0 +1,158 @@ | |||
# OpenOA Documentation | |||
|
|||
## Installation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RHammond2 I just looked at the compiled documentation, and think it would make more sense to start with the high-level software overview before the installation steps, to introduce people to the purpose of the software first. The order could be Software overview (intro part), installation, then analysis methods, PlantData Schema... What do you think about that order?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that makes a lot of sense, I'll make that change and do the 3.1 release if there's nothing else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds good to me! I don't think there's anything else, at least I didn't have any more comments.