Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Readme and Docs #267

Merged
merged 37 commits into from
Mar 14, 2024
Merged

Updates to Readme and Docs #267

merged 37 commits into from
Mar 14, 2024

Conversation

jordanperr
Copy link
Collaborator

  • Add table of analysis methods with citations (placeholder for now)
  • updated citation instructions
  • add a warning box showing a disclaimer related to use

… citations, updated citation instructions, and a warning box showing a disclaimer related to use
Copy link
Collaborator

@ejsimley ejsimley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice way to organize the readme. I added and reformatted some references, and added some suggested revisions to the text as comments. I still need to add some references for the wake loss and yaw misalignment methods, but will update those by the end of the week.

My only other comment is that we should also update the "About" section on GitHub when we merge this.

readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@RHammond2 RHammond2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together @jordanperr! This is a nice update to the project's README, and looking forward to getting it integrated into the docs site main page as well. I think I may have updated the docs main page for v3, though, so it might be worthwhile to crosscheck them and see if anything is worth salvaging from there prior to swapping it out with the README.

readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated
}
| Name | Description | Citations |
| --- | --- | --- |
| ``MonteCarloAEP`` | This routine estimates the long-term annual energy production (AEP) of a wind power plant (typically over 10-20 years) based on operational data from a shorter period of record (e.g., 1-3 years), along with the uncertainty. | [^2], [^3] |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the PRUF publications describe the AEP analysis method, so we could also cite references 1 and 4 if you think that's appropriate here.

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 72.49%. Comparing base (aa11436) to head (be9c574).

Files Patch % Lines
openoa/logging.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #267      +/-   ##
===========================================
- Coverage    72.49%   72.49%   -0.01%     
===========================================
  Files           29       29              
  Lines         3687     3690       +3     
  Branches       794      796       +2     
===========================================
+ Hits          2673     2675       +2     
- Misses         825      826       +1     
  Partials       189      189              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RHammond2 RHammond2 changed the base branch from main to develop February 22, 2024 21:21
@RHammond2
Copy link
Collaborator

@all-contributors
please add @jordanperr for documentation.
please add @ejsimley for documentation.
please add @RHammond2 for documentation.

Copy link

@RHammond2

File README.md was not found in the repository (NREL/OpenOA).

@RHammond2
Copy link
Collaborator

@all-contributors
please add @jordanperr for documentation.
please add @ejsimley for documentation.
please add @RHammond2 for documentation.

Copy link

@RHammond2

File README.md was not found in the repository (NREL/OpenOA).

@RHammond2
Copy link
Collaborator

@all-contributors
please add @jordanperr for documentation.
please add @ejsimley for documentation.
please add @RHammond2 for documentation.

Copy link

@RHammond2

File README.md was not found in the repository (NREL/OpenOA).

@RHammond2
Copy link
Collaborator

I've just pushed a couple updates. Commit 0c52c93 should resolve #278 and b09c1e0 should fix the issue where methods or functions wrapped in @logged_xx_call show as do_something(*args, **kwargs) instead of do_something(arg1, arg2, kwarg1).

@RHammond2 RHammond2 linked an issue Mar 4, 2024 that may be closed by this pull request
@RHammond2 RHammond2 marked this pull request as ready for review March 6, 2024 20:57
@ejsimley ejsimley self-requested a review March 11, 2024 16:44
sphinx/index.md Outdated
@@ -0,0 +1,158 @@
# OpenOA Documentation

## Installation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RHammond2 I just looked at the compiled documentation, and think it would make more sense to start with the high-level software overview before the installation steps, to introduce people to the purpose of the software first. The order could be Software overview (intro part), installation, then analysis methods, PlantData Schema... What do you think about that order?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that makes a lot of sense, I'll make that change and do the 3.1 release if there's nothing else.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good to me! I don't think there's anything else, at least I didn't have any more comments.

@RHammond2 RHammond2 merged commit a53308e into develop Mar 14, 2024
2 checks passed
@RHammond2 RHammond2 deleted the docs/update-readme branch March 14, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

readthedocs - functions not shown in sidebar for PlantData API
4 participants