Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dura mat mountain pref #124

Merged
merged 6 commits into from
Sep 30, 2024
Merged

Dura mat mountain pref #124

merged 6 commits into from
Sep 30, 2024

Conversation

tobin-ford
Copy link
Collaborator

Describe your changes

Quality of life changes made while creating down selected maps for DuraMAT

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 18.18182% with 72 lines in your changes missing coverage. Please review.

Project coverage is 65.71%. Comparing base (cd52739) to head (bedfc8d).
Report is 3 commits behind head on development.

Files with missing lines Patch % Lines
pvdeg/geospatial.py 6.66% 28 Missing ⚠️
pvdeg/utilities.py 14.28% 24 Missing ⚠️
pvdeg/scenario.py 31.03% 20 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #124      +/-   ##
===============================================
- Coverage        66.51%   65.71%   -0.81%     
===============================================
  Files               36       36              
  Lines             3396     3453      +57     
===============================================
+ Hits              2259     2269      +10     
- Misses            1137     1184      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobin-ford tobin-ford marked this pull request as ready for review September 27, 2024 21:22
@tobin-ford
Copy link
Collaborator Author

#123 Should happen before merging.

@martin-springer martin-springer merged commit edf6074 into development Sep 30, 2024
6 checks passed
@martin-springer martin-springer deleted the DuraMAT_mountain_pref branch September 30, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants