Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Degradation function signature changes #139

Closed
wants to merge 2 commits into from

Conversation

tobin-ford
Copy link
Collaborator

@tobin-ford tobin-ford commented Dec 11, 2024

Describe your changes

Changes signature for pvdeg.degradation.degradation

Takes a spectral dataframe with time index, columns for wavelength number and data for irradiance [W/m^2/nm] for each wavelength at each timestep. Takes matching conditions_df with matching time index and columns of relative humidity and temperature.

This resolves the weirdness with passing arguments to this function, and makes it more similar to the rest of pvdeg

There is a comprehensive note in the changelog, docstring and the tutorial has been updated appropriately (3 - Spectral Degradation)

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • Code changes are covered by tests.
  • Code changes have been evaluated for compatibility/integration with Scenario analysis (for future PRs)
  • Code changes have been evaluated for compatibility/integration with geospatial autotemplating (for future PRs)
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • What's new changelog has been updated in the docs

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 55.17241% with 13 lines in your changes missing coverage. Please review.

Project coverage is 65.09%. Comparing base (f7469ec) to head (0ee3550).

Files with missing lines Patch % Lines
pvdeg/degradation.py 45.83% 13 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #139      +/-   ##
===============================================
- Coverage        65.42%   65.09%   -0.34%     
===============================================
  Files               36       36              
  Lines             3575     3581       +6     
===============================================
- Hits              2339     2331       -8     
- Misses            1236     1250      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobin-ford
Copy link
Collaborator Author

Need to revisit integration with respect to time intervals and incorrect docstring

@tobin-ford tobin-ford closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants