Degradation function signature changes #139
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Changes signature for
pvdeg.degradation.degradation
Takes a spectral dataframe with time index, columns for wavelength number and data for irradiance [W/m^2/nm] for each wavelength at each timestep. Takes matching
conditions_df
with matching time index and columns of relative humidity and temperature.This resolves the weirdness with passing arguments to this function, and makes it more similar to the rest of
pvdeg
There is a comprehensive note in the changelog, docstring and the tutorial has been updated appropriately (3 - Spectral Degradation)
Type of change
Please delete options that are not relevant.
Checklist before requesting a review