-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Hybrid Configurations #1448
Conversation
UI look for input page dropdowns
container sorting
technology tables through startup rather than main
hard coded strings
- Assume grid outage applies to system output - Fix capitalization of Single Owner short name
- Replace `bin_name.Capitalize()` with `bin_name` so capitalization from startup script is preserved. Otherwise "PVWatts" is displayed as "Pvwatts". - Affects all configurations that use collapsible navigation menu (PV-Battery, etc.)
- Temporary fix for PV Capital Costs set PV capacity to -999 until we have separate capacities by component - Use PVWatts method to calculate hybrid PV land area
With fuel cell UI alignment fix
hybrid fuel cell configurations FOM have battery dispatch set to manual as automated dispatch fails with uninitialized discharge_hours
Remove capex table options from hybrid configs Update defaults
All of the files in api_autogen being deleted suggests some risk to PySAM functionality but I haven't had the chance to test it. Is there a reason those have been deleted? Has PySAM been tested with this branch at all? |
PySAM is way after the Fall Release. The api_autogen will need to be rewritten entirely as discussed previously at the hybrids meetings. The defaults and forms should be made to align with the SAM JSON instead of another variation. PySAM will not run with this branch and has not been tested. The purpose of this pull request is to get the hybrids changes into develop so that further pull requests for the Fall Release can be made against develop with all of the hybrid changes included to minimize startup, form, default updates and version upgrade merge conflicts. |
Addresses comment about electricity purchases in ssc pull request 1051
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the utility rate bug!
Time permitting, could the stuff under src get a pass for commented out code as well? I expect more of the TODOs here are still real, but it would be good to know which sections of commented out code are "reinstate this when we fix ABC" vs "pre-hybrids and no foreseeable use"
Defaults and UI for new hybrid configurations for Single Owner and Host Developer financial models:
PVWatts Wind Battery Hybrid
PVWatts Wind FuelCell Battery Hybrid
Photovoltaic Wind Battery Hybrid
Generic PVWatts Wind FuelCell Battery Hybrid
Goes with: