Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Hybrid Configurations #1448

Merged
merged 200 commits into from
Sep 18, 2023
Merged

New Hybrid Configurations #1448

merged 200 commits into from
Sep 18, 2023

Conversation

cpaulgilman
Copy link
Collaborator

@cpaulgilman cpaulgilman commented Sep 14, 2023

Defaults and UI for new hybrid configurations for Single Owner and Host Developer financial models:

PVWatts Wind Battery Hybrid

PVWatts Wind FuelCell Battery Hybrid

Photovoltaic Wind Battery Hybrid

Generic PVWatts Wind FuelCell Battery Hybrid

Goes with:

mjprilliman and others added 30 commits March 16, 2023 12:10
technology tables through startup rather than main
- Assume grid outage applies to system output
- Fix capitalization of Single Owner short name
- Replace `bin_name.Capitalize()` with `bin_name` so capitalization from startup script is preserved. Otherwise "PVWatts" is displayed as "Pvwatts".
- Affects all configurations that use collapsible navigation menu (PV-Battery, etc.)
- Temporary fix for PV Capital Costs set PV capacity to -999 until we have separate capacities by component
- Use PVWatts method to calculate hybrid PV land area
cpaulgilman and others added 7 commits September 8, 2023 14:28
With fuel cell UI alignment fix
hybrid fuel cell configurations FOM have battery dispatch set to manual as automated dispatch fails with uninitialized discharge_hours
Remove capex table options from hybrid configs

Update defaults
@cpaulgilman cpaulgilman added new feature requires help revision Requires a Help revision before releasing public version labels Sep 14, 2023
@cpaulgilman cpaulgilman added this to the SAM Fall 2023 Release milestone Sep 14, 2023
@cpaulgilman cpaulgilman requested review from brtietz, sjanzou and janinefreeman and removed request for sjanzou September 14, 2023 20:02
@cpaulgilman cpaulgilman changed the title New hybrid configurations New Hybrid Configurations Sep 14, 2023
@brtietz
Copy link
Collaborator

brtietz commented Sep 14, 2023

Minor defaults issue: battery dispatch schedules are not set for some configurations:

image

PVWatts-Wind-Battery looks ok but the others are all 1s.

@brtietz
Copy link
Collaborator

brtietz commented Sep 14, 2023

All of the files in api_autogen being deleted suggests some risk to PySAM functionality but I haven't had the chance to test it. Is there a reason those have been deleted? Has PySAM been tested with this branch at all?

@sjanzou
Copy link
Collaborator

sjanzou commented Sep 15, 2023

All of the files in api_autogen being deleted suggests some risk to PySAM functionality but I haven't had the chance to test it. Is there a reason those have been deleted? Has PySAM been tested with this branch at all?

PySAM is way after the Fall Release. The api_autogen will need to be rewritten entirely as discussed previously at the hybrids meetings. The defaults and forms should be made to align with the SAM JSON instead of another variation. PySAM will not run with this branch and has not been tested.

The purpose of this pull request is to get the hybrids changes into develop so that further pull requests for the Fall Release can be made against develop with all of the hybrid changes included to minimize startup, form, default updates and version upgrade merge conflicts.

Addresses comment about electricity purchases in ssc pull request 1051
Copy link
Collaborator

@brtietz brtietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the utility rate bug!

Time permitting, could the stuff under src get a pass for commented out code as well? I expect more of the TODOs here are still real, but it would be good to know which sections of commented out code are "reinstate this when we fix ABC" vs "pre-hybrids and no foreseeable use"

@sjanzou sjanzou merged commit c06b992 into develop Sep 18, 2023
4 checks passed
@cpaulgilman cpaulgilman deleted the hybrids branch October 3, 2023 16:48
@cpaulgilman cpaulgilman removed the requires help revision Requires a Help revision before releasing public version label Nov 10, 2023
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added to release notes PR and/or issue has been added to release notes for a public release new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants