-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api cleanup #15
Api cleanup #15
Conversation
still cleaning up some comments
changed `download_demo_files` to `copy_demo_files`
…y also `destination_id` need a way to make it so that these are optional for this and probabbly mandator for speed limit train sim???
… cryptic error message
E RuntimeError: [altrios-core/src/train/train_config.rs:363] E `origin_id`: "Funkytown" not found in `location_map` keys: ["Minneapolis", "Hibbing", "Allouez", "Superior"]
need time to asses whether exhaustive replacement makes sense all tests but 1 pass
made use of `SHOW_PLOTS` more broadly
will merge this branch via PR and then fix in a separate branch
@calbaker I also don't like the commented-out portions of the example that would be making plots. We should either make the plot or delete the code in my opinion. I do like what you have done with the car yaml files instead of the csv. That seems a lot cleaner. I have not looked at the rust changes in detail. I'll try to give it look on Thursday. |
@sakhtar312 could you try to get these tests passing? |
@calbaker the tests are passing now. Installing the project in developer mode in tests.yaml file (adding -e flag to pip install .) did the trick. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the changes and both rust and python tests are passing. Approving the pull request.
Fix `from_csv_file` function
RailVehicle
directly in place ofRailVehicleMap
in several places but not exhaustivelyaltrios/python/altrios/tests/test_rail_vehicles.py
Lines 4 to 17 in cfcc11e