This repository has been archived by the owner on Jan 7, 2018. It is now read-only.
Default logs filter #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding_ gatekeeper error messages (i.e. anything that does not hit the backend API). Extends a test to cover this
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For 18F/api.data.gov#241
To help alleviate slowness in stats pages due to too many api-over-limit logs, this defaults these logs to exclude logs which had a gatekeeper error message. This should therefore show only "legitimate" traffic on initial view. As the initial view contains a filter, the filters will also start expanded:
This PR also extends an existing spec to test that this initial filter can be removed.