-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable heterogeneous inflows in yaw optimization routines #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ous inflows during yaw optimization.
rafmudaf
reviewed
Jul 6, 2023
rafmudaf
added
bug
Something isn't working
enhancement
An improvement of an existing feature
labels
Jul 6, 2023
rafmudaf
approved these changes
Jul 7, 2023
Also addresses discussion #658 |
@paulf81 Just checking in whether you want to review this one |
@misi9170 are going to review it together at 1130, thanks for checking! |
paulf81
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neither Serial Refine nor the scipy minimize routine for yaw angle optimization currently work with a heterogeneous inflow (the issue for Serial Refine is identified in #673). This pull request addresses that.
Additionally, turbine.py is updated to allow power to be extrapolated outside of the specified range in the turbine input file. Sampling with a wind speed outside of the interpolation range returns a power of 0. Finally, a minor update is made to turbine.py to warn the user if the
rotor_effective_velocities
contains any negative entries, which can happen in situations where turbines are very close together.To reproduce the existing error with heterogeneous inflows and yaw optimizations, run
As an example of a negative wind speed raising a power interpolation error, run
Closes #673
Ready for review/merge.