New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Gridded layout opt incorrectly generating spanning grid #984

Merged

misi9170 merged 1 commit into NREL:develop from misi9170:bugfix/gridded-layout-opt

Sep 19, 2024

Collaborator

misi9170 commented Sep 19, 2024

This small pull request fixes two bugs and adds one enhancement to the recently developed LayoutOptimizationGridded class.

Fixes an incorrect line that could result in a "spanning" layout that did not actually span the boundary area
Ensures that only a single rotor_diameter is returned, which was causing problem as the dimension of fmodel.core.farm.rotor_diameters is not always 1.
Makes minor enhancement to ensure that n_turbines_max is of type int, rather than a float that will always be a whole number, which is then useful for indexing arrays/lists.


          Bugfix for rotor_diameters; error in width of grid; make sure n_turbi…

0da081a

…nes_max is of type int.

misi9170 added bug enhancement labels

misi9170 requested a review from paulf81

September 19, 2024 19:05

paulf81 approved these changes

View reviewed changes

Collaborator

paulf81 left a comment

These changes make sense to me

misi9170 merged commit a1c2134 into NREL:develop

8 checks passed

misi9170 mentioned this pull request

FLORIS v4.2 #994

Draft

4 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug enhancement