Consistent monthly and annual energy labels #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `monthly_energy` "Monthly AC energy in Year 1" * `annual_energy` "Annual AC energy in Year 1" * Fix capitalization as convenient * Don't change labels for SWH, and for some CSP models that have long labels, or for Marine Energy, etc.
mjprilliman
approved these changes
Nov 5, 2024
| { SSC_OUTPUT, SSC_ARRAY, "monthly_energy", "Monthly energy", "kWh", "", "Monthly", "", "LENGTH=12", "" }, | ||
| { SSC_OUTPUT, SSC_MATRIX, "annual_energy_distribution_time","Annual energy production as function of Time", "", "", "Heatmaps", "", "", "" }, | ||
| { SSC_OUTPUT, SSC_ARRAY, "dc_monthly", "Monthly DC energy", "kWh", "", "Monthly", "", "LENGTH=12", "" }, | ||
| { SSC_OUTPUT, SSC_ARRAY, "ac_monthly", "Monthly AC energy", "kWh", "", "Monthly", "", "LENGTH=12", "" }, |
There was a problem hiding this comment.
This is probably for a different issue, but I believe ac_monthly and monthly_energy will always be the same. Do we need both?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NREL/SAM#1876
Use following labels as much as possible
monthly_energy"Monthly energy in Year 1"annual_energy"Annual energy in Year 1"