Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade jest #100

Merged
merged 1 commit into from
Dec 3, 2017
Merged

Upgrade jest #100

merged 1 commit into from
Dec 3, 2017
+304 −225

Conversation

sdunster
Copy link
Member

@sdunster sdunster commented Dec 3, 2017

@sdunster
Upgrade jest
d2c4884 
* Beta version because it has a bug fix for testing rejected promises:
  * jestjs/jest#4884
* Needed for upcoming unit tests for events/schedules API
cmiceli
cmiceli approved these changes Dec 3, 2017
View reviewed changes
Copy link
Contributor

@cmiceli cmiceli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepting to unbreak work, but it seems shitty to use beta level software if we can avoid.

@sdunster
Copy link
Member Author

sdunster commented Dec 3, 2017

@cmiceli FYI the whole of react native is beta

@sdunster sdunster merged commit eafd13c into master Dec 3, 2017
@sdunster sdunster deleted the sdunster.upgrade_jest branch December 4, 2017 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmiceli cmiceli cmiceli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdunster @cmiceli