Add docstrings and the parameter to row_groups_per_part
to the MerlinDataLoader class
#590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #550
@bbozkaya runs different tests (see image below) of repartitioning a parquet file (using pandas or cudf) and it seems that
MerlinDataLoader
always loads the dataset files with 1 partition even though we partition to multiple groups when saving the parquet file (as recommended here). To take into account these partitions, we should pass the parameterrow_groups_per_part=True
to the merlin.io.Dataset.Goals ⚽
row_groups_per_part
toMerlinDataLoader
so as to load the dataset with the correct partitions.MerlinDataLoader
to explain the different parameters.