Fetch release branches so that we can figure out the release branch #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jperez999
approved these changes
Feb 3, 2023
Documentation previewhttps://nvidia-merlin.github.io/Transformers4Rec/review/pr-609 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #608
Adds a fetch of the release branches so that we can figure out the release branch name that the tag corresponds to. This is required because the default checkout behaviour of the
actions/checkoutstep is to fetch only the single commit without any branch names.An alternative to this is to specify
fetch-depth: 0on theactions/checkoutstep which will result in a full fetch of all commits, branches, and tags. However, that is slightly slower due to it fetching everything instead of the more minimal set of commit data. And would apply to every build the way it's setup now and not only for the publish.