Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update usage of use_amp to use_cuda_amp for transformers>=4.20 #627

Merged
merged 4 commits into from
Mar 22, 2023
Merged

Update usage of use_amp to use_cuda_amp for transformers>=4.20 #627

merged 4 commits into from
Mar 22, 2023

Conversation

oliverholworthy
Copy link
Member

@oliverholworthy oliverholworthy commented Mar 1, 2023 •
edited
Loading

Relates to #568

  • Support transformers package version >=4.20
  • and earlier versions too by checking both use_cuda_amp and use_amp attributes in the trainer.

@oliverholworthy oliverholworthy added the chore Maintenance for the repository label Mar 1, 2023
@oliverholworthy oliverholworthy added this to the Merlin 23.03 milestone Mar 1, 2023
@oliverholworthy oliverholworthy self-assigned this Mar 1, 2023
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Documentation preview

https://nvidia-merlin.github.io/Transformers4Rec/review/pr-627

@oliverholworthy oliverholworthy marked this pull request as ready for review March 22, 2023 11:05
@karlhigley karlhigley merged commit ed88361 into NVIDIA-Merlin:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlhigley karlhigley karlhigley approved these changes

Assignees

@oliverholworthy oliverholworthy

Labels
chore Maintenance for the repository
Projects
None yet
Milestone
Merlin 23.03
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverholworthy @karlhigley