Add Transformers Torch Extras to install requirements #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverholworthy
force-pushed
the
transformers-torch-dep
branch
from
a25a0e0
to
f981d8e
Compare
Documentation previewhttps://nvidia-merlin.github.io/Transformers4Rec/review/pr-699 |
sararb
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
torchextra fromtransformerspackage to base requirements.This results in moving the torch dependency from an optional depdendency to an install depdendency. Since Transformers4Rec is only implemented for Torch and won't work without it, this seems ok and simplifies the pip install for the package.
We'll also pickup any depdendencies added to the torch extras in
transformerslike the recently addedacceleratedependency.