Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tf.function for list column operations #89

Merged
merged 1 commit into from
Dec 27, 2022
Merged

Use tf.function for list column operations #89

merged 1 commit into from
Dec 27, 2022

Conversation

edknv
Copy link
Contributor

@edknv edknv commented Dec 27, 2022

Addresses #74.

See related PR NVIDIA-Merlin/models#938 for more details.

@edknv edknv added bug Something isn't working ci labels Dec 27, 2022
@edknv edknv added this to the Merlin 22.12 milestone Dec 27, 2022
@edknv edknv self-assigned this Dec 27, 2022
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/dataloader/review/pr-89

EvenOldridge
EvenOldridge approved these changes Dec 27, 2022
View reviewed changes
Copy link
Member

@EvenOldridge EvenOldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks good.

We probably need something in our documentation warning users about using RaggedTensor directly.

@edknv edknv merged commit 5b3fe46 into NVIDIA-Merlin:main Dec 27, 2022
@edknv edknv deleted the ragged_tf_function branch December 27, 2022 19:03
edknv added a commit that referenced this pull request Dec 27, 2022
@edknv
Use tf.function for list column operations (#89)
fd5d3fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvenOldridge EvenOldridge EvenOldridge approved these changes

Assignees

@edknv edknv

Labels
bug Something isn't working ci
Projects
None yet
Milestone
Merlin 22.12
Development

Successfully merging this pull request may close these issues.
2 participants
@edknv @EvenOldridge