implement review suggestions #1062
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Documentation preview |
|
rerun tests |
| tb.execute_cell(list(range(0, 38))) | ||
|
|
||
| with run_triton_server("/tmp/ensemble", grpc_port=8001): | ||
| with run_triton_server("/tmpdir/ensemble", grpc_port=8001): |
There was a problem hiding this comment.
This will need to be something like f"{tmpdir}/ensemble to convert the temp directory name into a the path.
And the tmpdir fixture needs to be added as a named in the arguments list to be available inside the body of the test. There's a notebook test here that uses tmpdir as an example
https://github.com/NVIDIA-Merlin/models/blob/v23.02.00/tests/unit/tf/examples/test_06_advanced_own_architecture.py#L13
|
rerun tests |
adding comments to the PR to trigger re-runs of tests I don't think is required/works anymore. This was previously to re-trigger a test run of the GPU-based tests that were running in Jenkins. Now that we have a self-hosted GitHub Actions runner for that, the way to trigger a re-run is to open the Details page of the relevant failed check and use the Re-run jobs button at the top right of the page.
|
|
Thank you for the heads up, @oliverholworthy! 🙂 |
radekosmulski
force-pushed
the
implement_review_comments
branch
from
f94ef51
to
5ff0765
Compare
We merged #1045 to meet the cutoff, but there were some outstanding review comments from @rnyak and @edknv. This PR implements the suggestions mentioned on #1045