Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pretrained embs example #1100

Merged
merged 2 commits into from
May 23, 2023
Merged

Conversation

radekosmulski
Copy link
Contributor

This updates the pretrained embeddings use case to reflect the new functionality.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@radekosmulski radekosmulski force-pushed the update_example_pretrained_embs branch from ed14e73 to 2f3088f Compare May 18, 2023 00:27
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/models/review/pr-1100

Copy link
Contributor

@bschifferer bschifferer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great to me. Can we add a description and print

train.schema
loader.output_schema

and explain that the loader adds the column pretrained_movie_embeddings to the schema + the Tags.Embedding ?

@radekosmulski radekosmulski merged commit 2c6eafc into main May 23, 2023
@rnyak rnyak deleted the update_example_pretrained_embs branch May 23, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants