Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add get_config() to AverageEmbeddingsByWeightFeature class #968

Merged
merged 2 commits into from
Feb 4, 2023
Merged

add get_config() to AverageEmbeddingsByWeightFeature class #968

merged 2 commits into from
Feb 4, 2023

Conversation

rnyak
Copy link
Contributor

@rnyak rnyak commented Jan 31, 2023 •
edited
Loading

Currently AverageEmbeddingsByWeightFeature class is missing a get_config() function, so we get error when we try to use it in the embeddings layer.

issues needs to be solved as a follow up:

  • this class is not reducing the 3D to 2D which is expected.
  • this class is not called when we use shared embeddings.

@rnyak rnyak added the enhancement New feature or request label Jan 31, 2023
@rnyak rnyak added this to the Merlin 23.02 milestone Jan 31, 2023
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/models/review/pr-968

@rnyak rnyak added bug Something isn't working P0 labels Feb 1, 2023
@rnyak
Copy link
Contributor Author

rnyak commented Feb 1, 2023

rerun tests

@rnyak rnyak mentioned this pull request Feb 1, 2023
Closed
@rnyak
Copy link
Contributor Author

rnyak commented Feb 3, 2023

rerun tests

@karlhigley karlhigley merged commit c8d34ad into main Feb 4, 2023
@rnyak rnyak deleted the avg_emd_class branch February 5, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sararb sararb sararb approved these changes

@gabrielspmoreira gabrielspmoreira Awaiting requested review from gabrielspmoreira

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request P0
Projects
None yet
Milestone
Merlin 23.02
Development

Successfully merging this pull request may close these issues.
3 participants
@rnyak @sararb @karlhigley