[hdEmbree] Initial UsdLux reference implementation #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmolodo
force-pushed
the
pr/hdEmbree-usd-lux-ref-implementation
branch
from
34d9a31
to
a6a9136
Compare
pmolodo
force-pushed
the
pr/hdEmbree-usd-lux-ref-implementation
branch
from
a6a9136
to
9088c1b
Compare
pmolodo
force-pushed
the
pr/hdEmbree-usd-lux-prep
branch
2 times, most recently
from
dabdeb5
to
5d519c7
Compare
pmolodo
force-pushed
the
pr/hdEmbree-usd-lux-ref-implementation
branch
from
9088c1b
to
2c9ff46
Compare
pmolodo
changed the base branch from
pr/hdEmbree-usd-lux-prep
to
pr/hdEmbree-respect-PXR_WORK_THREAD_LIMIT
pmolodo
force-pushed
the
pr/hdEmbree-usd-lux-ref-implementation
branch
from
2c9ff46
to
c0aebc7
Compare
pmolodo
force-pushed
the
pr/hdEmbree-respect-PXR_WORK_THREAD_LIMIT
branch
from
fbdd452
to
0a241c1
Compare
pmolodo
force-pushed
the
pr/hdEmbree-usd-lux-ref-implementation
branch
from
c0aebc7
to
be07932
Compare
This modifies the hdEmbree example plugin to do direct lighting so as to provide a reference implementation of the expected behaviour for UsdLux. If no lights are present in the stage, the old ambient occlusion path will be used.
pmolodo
force-pushed
the
pr/hdEmbree-usd-lux-ref-implementation
branch
from
be07932
to
76c2135
Compare
pmolodo
force-pushed
the
pr/hdEmbree-respect-PXR_WORK_THREAD_LIMIT
branch
from
0a241c1
to
89e974f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
This modifies the hdEmbree example plugin to do direct lighting so as to provide a reference implementation of the expected behaviour for UsdLux.
If no lights are present in the stage, the old ambient occlusion path will be used.
NOTE: This chain of PRs was made separate from the PR documenting expected behavior: