Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to build with asan. #933

Merged
merged 2 commits into from
Sep 23, 2023
Merged

Add an option to build with asan. #933

merged 2 commits into from
Sep 23, 2023

Conversation

wujingyue
Copy link
Collaborator

@wujingyue wujingyue commented Sep 23, 2023

Tested:

$ pip install -e .
$ nm -an bin/nvfuser_tests | grep asan
<empty>
$ python setup.py develop --build-with-asan
$ nm -an bin/nvfuser_tests | grep asan
...
00000000024f3840 B __odr_asan._ZN7nvfuser38NVFuserTest_FusionDefinition_CUDA_Test10test_info_E
00000000024f38e0 B __odr_asan._ZN7nvfuser35NVFuserTest_PyFusionCache_CUDA_Test10test_info_E
00000000024f3980 B __odr_asan._ZN7nvfuser43NVFuserTest_RecordFunctorEquality_CUDA_Test10test_info_E
0000000002528fa0 B __odr_asan._ZN5torch8autograd47_GLOBAL__N__551c3bf8_14_rng_kernels_cu_8fdfe6fb13graph_task_idE

@wujingyue wujingyue requested a review from xwang233 September 23, 2023 04:14
Copy link
Collaborator

@xwang233 xwang233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding that!

@naoyam
Copy link
Collaborator

naoyam commented Sep 23, 2023

Don't you need to do some additional configurations like ASAN_OPTIONS? Last time I tried asan I had some problem with CUDA. Something like google/sanitizers#629

@wujingyue wujingyue merged commit 5169d12 into main Sep 23, 2023
3 checks passed
@wujingyue wujingyue deleted the asan branch September 23, 2023 18:18
@wujingyue
Copy link
Collaborator Author

Don't you need to do some additional configurations like ASAN_OPTIONS? Last time I tried asan I had some problem with CUDA. Something like google/sanitizers#629

Yes. That's needed at run time not build time.

@naoyam
Copy link
Collaborator

naoyam commented Sep 23, 2023

Don't you need to do some additional configurations like ASAN_OPTIONS? Last time I tried asan I had some problem with CUDA. Something like google/sanitizers#629

Yes. That's needed at run time not build time.

Could you please add something to https://github.com/NVIDIA/Fuser/wiki/Developer-guide?

@wujingyue
Copy link
Collaborator Author

Don't you need to do some additional configurations like ASAN_OPTIONS? Last time I tried asan I had some problem with CUDA. Something like google/sanitizers#629

Yes. That's needed at run time not build time.

Could you please add something to https://github.com/NVIDIA/Fuser/wiki/Developer-guide?

Done! https://github.com/NVIDIA/Fuser/wiki/Developer-guide#asan

@wujingyue wujingyue added the enhancement New feature or request label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants