-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readme with links to arxiv and ai playground #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submitting partial review on documentation only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not fully done yet, but submitting partial review as I need to take a break.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished 1st pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed updating path to one script ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks all for the quick turnaround on this!
There's a non-negligible chance that some of my suggested changes might have broken something => if it's easy to check, wouldn't hurt to re-run the tutorial over the week-end to make sure all is working as intended
0105b03
to
a9339f7
Compare
b7d30aa
to
81c397a
Compare
Signed-off-by: Zhilin Wang <zhilinw@nvidia.com>
Signed-off-by: jiaqiz <jiaqiz@nvidia.com>
Signed-off-by: jiaqiz <jiaqiz@nvidia.com>
Signed-off-by: jiaqiz <jiaqiz@nvidia.com>
107cfd5
to
455e155
Compare
* add steerlm Signed-off-by: Zhilin Wang <zhilinw@nvidia.com> * add license for common.py Signed-off-by: jiaqiz <jiaqiz@nvidia.com> * fix build Signed-off-by: Gerald Shen <geshen@nvidia.com> * concat datasets before training since only 1 epoch is supported now Signed-off-by: jiaqiz <jiaqiz@nvidia.com> * concat AC-SFT training data to get 2 epochs Signed-off-by: jiaqiz <jiaqiz@nvidia.com> --------- Signed-off-by: Zhilin Wang <zhilinw@nvidia.com> Signed-off-by: jiaqiz <jiaqiz@nvidia.com> Signed-off-by: Gerald Shen <geshen@nvidia.com> Co-authored-by: jiaqiz <jiaqiz@nvidia.com> Co-authored-by: Gerald Shen <geshen@nvidia.com>
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Changelog
Usage
# Add a code snippet demonstrating how to use this
Before your PR is "Ready for review"
Pre checks:
Checklist when contributing a new algorithm
max_steps=-1
andvalidation
?Additional Information