Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme with links to arxiv and ai playground #25

Merged
merged 5 commits into from
Dec 4, 2023

Conversation

Zhilin123
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

@Zhilin123 Zhilin123 requested a review from gshennvm November 30, 2023 23:30
docs/user-guide/SteerLM.rst Outdated Show resolved Hide resolved
docs/user-guide/SteerLM.rst Show resolved Hide resolved
docs/user-guide/SteerLM.rst Outdated Show resolved Hide resolved
@odelalleau odelalleau self-requested a review December 1, 2023 18:33
Copy link
Collaborator

@odelalleau odelalleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitting partial review on documentation only

docs/user-guide/SteerLM.rst Outdated Show resolved Hide resolved
docs/user-guide/SteerLM.rst Outdated Show resolved Hide resolved
docs/user-guide/SteerLM.rst Show resolved Hide resolved
docs/user-guide/SteerLM.rst Outdated Show resolved Hide resolved
docs/user-guide/SteerLM.rst Outdated Show resolved Hide resolved
docs/user-guide/SteerLM.rst Outdated Show resolved Hide resolved
docs/user-guide/SteerLM.rst Outdated Show resolved Hide resolved
docs/user-guide/SteerLM.rst Outdated Show resolved Hide resolved
docs/user-guide/SteerLM.rst Outdated Show resolved Hide resolved
docs/user-guide/SteerLM.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@odelalleau odelalleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fully done yet, but submitting partial review as I need to take a break.

README.md Outdated Show resolved Hide resolved
scripts/attribute_annotate.py Outdated Show resolved Hide resolved
scripts/attribute_annotate.py Outdated Show resolved Hide resolved
scripts/attribute_annotate.py Outdated Show resolved Hide resolved
scripts/attribute_annotate.py Outdated Show resolved Hide resolved
scripts/preprocess_openassistant_data.py Outdated Show resolved Hide resolved
scripts/preprocess_openassistant_data.py Outdated Show resolved Hide resolved
scripts/preprocess_openassistant_data.py Outdated Show resolved Hide resolved
scripts/preprocess_openassistant_data.py Outdated Show resolved Hide resolved
scripts/preprocess_openassistant_data.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@odelalleau odelalleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished 1st pass

Copy link
Collaborator

@odelalleau odelalleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed updating path to one script ;)

docs/user-guide/SteerLM.rst Outdated Show resolved Hide resolved
docs/user-guide/SteerLM.rst Outdated Show resolved Hide resolved
@odelalleau odelalleau self-requested a review December 2, 2023 03:28
odelalleau
odelalleau previously approved these changes Dec 2, 2023
Copy link
Collaborator

@odelalleau odelalleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks all for the quick turnaround on this!

There's a non-negligible chance that some of my suggested changes might have broken something => if it's easy to check, wouldn't hurt to re-run the tutorial over the week-end to make sure all is working as intended

Zhilin123 and others added 5 commits December 3, 2023 14:24
Signed-off-by: Zhilin Wang <zhilinw@nvidia.com>
Signed-off-by: jiaqiz <jiaqiz@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: jiaqiz <jiaqiz@nvidia.com>
@gshennvm gshennvm merged commit 1d50757 into main Dec 4, 2023
1 of 2 checks passed
rohitrango pushed a commit to rohitrango/NeMo-Aligner that referenced this pull request Jun 25, 2024
* add steerlm

Signed-off-by: Zhilin Wang <zhilinw@nvidia.com>

* add license for common.py

Signed-off-by: jiaqiz <jiaqiz@nvidia.com>

* fix build

Signed-off-by: Gerald Shen <geshen@nvidia.com>

* concat datasets before training since only 1 epoch is supported now

Signed-off-by: jiaqiz <jiaqiz@nvidia.com>

* concat AC-SFT training data to get 2 epochs

Signed-off-by: jiaqiz <jiaqiz@nvidia.com>

---------

Signed-off-by: Zhilin Wang <zhilinw@nvidia.com>
Signed-off-by: jiaqiz <jiaqiz@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Co-authored-by: jiaqiz <jiaqiz@nvidia.com>
Co-authored-by: Gerald Shen <geshen@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants