Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Degert/fix dpo capitalisation #34

Merged
merged 3 commits into from
Dec 2, 2023
Merged

Conversation

trias702
Copy link
Collaborator

@trias702 trias702 commented Dec 2, 2023

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

Signed-off-by: trias702 <daniel.egert@gmail.com>
Signed-off-by: trias702 <daniel.egert@gmail.com>
@trias702 trias702 requested a review from gshennvm December 2, 2023 02:47
@trias702 trias702 added the bug Something isn't working label Dec 2, 2023
@gshennvm gshennvm merged commit 8ca2e04 into main Dec 2, 2023
1 of 2 checks passed
rohitrango pushed a commit to rohitrango/NeMo-Aligner that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants