Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adds missing license header on tests and corrects file modes #388

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

terrykong
Copy link
Collaborator

@terrykong terrykong commented Nov 7, 2024

What does this PR do ?

Rebase stack

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

@terrykong terrykong changed the title Tk/test license and mode chore: adds missing license header on tests and corrects file modes Nov 7, 2024
@terrykong terrykong requested a review from ko3n1g November 7, 2024 19:50
@terrykong terrykong force-pushed the tk/test-license-and-mode branch 2 times, most recently from 0806f7d to 9039b49 Compare November 14, 2024 18:32
@terrykong terrykong force-pushed the tk/test-license-and-mode branch 4 times, most recently from 15a05ac to b10639b Compare November 15, 2024 07:38
Signed-off-by: Terry Kong <terryk@nvidia.com>
@terrykong terrykong force-pushed the tk/test-license-and-mode branch from b10639b to 22f4cb2 Compare November 15, 2024 07:46
@terrykong terrykong added the Run CICD Set + un-set to retrigger label Nov 15, 2024
@terrykong terrykong enabled auto-merge (squash) November 15, 2024 07:47
@terrykong terrykong added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Nov 15, 2024
@terrykong terrykong merged commit 852d847 into main Nov 15, 2024
17 checks passed
@terrykong terrykong deleted the tk/test-license-and-mode branch November 15, 2024 19:11
abukharin3 pushed a commit to abukharin3/NeMo-Aligner that referenced this pull request Nov 22, 2024
…VIDIA#388)

Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: abukharin <abukharin@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run CICD Set + un-set to retrigger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants