Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dist-optim fixes #392

Closed
wants to merge 4 commits into from
Closed

Conversation

akoumpa
Copy link
Member

@akoumpa akoumpa commented Nov 8, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

akoumpa and others added 3 commits November 8, 2024 02:50
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
for more information, see https://pre-commit.ci

Signed-off-by: NeMo-Aligner CI <nemo-aligner-ci@nvidia.com>
@github-actions github-actions bot added the Utils label Nov 8, 2024
@akoumpa akoumpa changed the title Akoumparouli/mixtral fixes Dist-optim fixes Nov 8, 2024
@terrykong
Copy link
Collaborator

@akoumpa Could you PR against #380 ? I caught a few of the changes missing for mcore dist opt over there

@terrykong
Copy link
Collaborator

Closing so you can re-create a PR targetting that branch

@terrykong terrykong closed this Nov 8, 2024
@akoumpa
Copy link
Member Author

akoumpa commented Nov 8, 2024

synced with @terrykong offline; will pull 392 in 380.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants