Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update TRTLLM export to the new megatron-core-export path #419

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: update TRTLLM export to the new megatron-core-export path #419

wants to merge 5 commits into from

Conversation

terrykong
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

@terrykong @pre-commit-ci
feat: TRTLLM API handle tokenizers without pad_id (e.g., tiktoken) (#399
eb2db8b 
)

Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: NeMo-Aligner CI <nemo-aligner-ci@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@terrykong terrykong changed the title Tk/mcore export feat: update TRTLLM export to the new megatron-core-export path Nov 22, 2024
@terrykong terrykong added the Run CICD Set + un-set to retrigger label Nov 22, 2024
@terrykong terrykong added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Nov 22, 2024
abukharin3 and others added 4 commits November 22, 2024 22:07
@abukharin3 @pre-commit-ci @terrykong
feat: adds REINFORCE algorithm (#357)
716e503 
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: NeMo-Aligner CI <nemo-aligner-ci@nvidia.com>
Signed-off-by: abukharin <abukharin@nvidia.com>
Co-authored-by: abukharin <abukharin@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Terry Kong <terryk@nvidia.com>
@terrykong
feat: update Aligner to use mcore export
79eed88 
Signed-off-by: Terry Kong <terryk@nvidia.com>
@terrykong
require grad_sync to be true now for this ckpt
7f75e47 
Signed-off-by: Terry Kong <terryk@nvidia.com>
@terrykong
bump commits to public ones that have mcore-export support
06817b0 
Signed-off-by: Terry Kong <terryk@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Run CICD Set + un-set to retrigger
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terrykong @abukharin3