Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Allow dry-run of release #421

Merged
merged 1 commit into from
Nov 28, 2024
Merged

ci: Allow dry-run of release #421

merged 1 commit into from
Nov 28, 2024

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Nov 27, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@pablo-garay pablo-garay merged commit 35d0c59 into main Nov 28, 2024
17 checks passed
@pablo-garay pablo-garay deleted the ko3n1g/ci/release-dry-run branch November 28, 2024 00:20
terrykong pushed a commit that referenced this pull request Dec 5, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants