Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sync main to dev #446

Merged
merged 2 commits into from
Dec 13, 2024
Merged

chore: sync main to dev #446

merged 2 commits into from
Dec 13, 2024

Conversation

github-actions[bot]
Copy link
Contributor

sync-branches: New code has just landed in main, so let's bring dev up to speed!

Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
@terrykong terrykong changed the title sync: main to dev chore: sync main to dev Dec 11, 2024
@terrykong terrykong added the Run CICD Set + un-set to retrigger label Dec 11, 2024
@terrykong terrykong enabled auto-merge December 11, 2024 22:25
@terrykong terrykong disabled auto-merge December 11, 2024 22:25
@terrykong terrykong enabled auto-merge December 11, 2024 22:26
@terrykong
Copy link
Collaborator

@ashors1 checked that both dev and main succeed on their branches and there's some failure that only appears when we merge

main: https://github.com/NVIDIA/NeMo-Aligner/actions/runs/12302899702
dev: https://github.com/NVIDIA/NeMo-Aligner/pull/448/checks

Since we don't want to patch on main since that would cause a break, i'm merging this and we'll fix on dev

@terrykong terrykong disabled auto-merge December 13, 2024 00:19
@terrykong terrykong merged commit f817eb1 into dev Dec 13, 2024
45 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run CICD Set + un-set to retrigger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants