Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add final status check #455

Merged
merged 19 commits into from
Dec 18, 2024
Merged

ci: Add final status check #455

merged 19 commits into from
Dec 18, 2024

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Dec 17, 2024

What does this PR do ?

  • Adds a final check so that we can handle dynamic status checks
  • Adds option to skip CI by label Skip CICD
  • Adds auto-skip for changes inside docs/ only

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g added the Run CICD Set + un-set to retrigger label Dec 17, 2024
@github-actions github-actions bot added the CI label Dec 17, 2024
@ko3n1g ko3n1g added Skip CICD and removed Run CICD Set + un-set to retrigger labels Dec 17, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g marked this pull request as draft December 17, 2024 23:23
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g added Skip CICD Run CICD Set + un-set to retrigger and removed Skip CICD labels Dec 17, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Dec 18, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g added Skip CICD and removed Run CICD Set + un-set to retrigger labels Dec 18, 2024
@ko3n1g ko3n1g requested a review from terrykong December 18, 2024 00:20
@ko3n1g ko3n1g marked this pull request as ready for review December 18, 2024 00:20
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@terrykong terrykong added Run CICD Set + un-set to retrigger Skip CICD and removed Skip CICD Run CICD Set + un-set to retrigger labels Dec 18, 2024
@terrykong terrykong enabled auto-merge (squash) December 18, 2024 00:30
@terrykong terrykong disabled auto-merge December 18, 2024 00:34
@terrykong terrykong enabled auto-merge (squash) December 18, 2024 00:35
@ko3n1g ko3n1g disabled auto-merge December 18, 2024 08:23
@ko3n1g ko3n1g enabled auto-merge (squash) December 18, 2024 08:23
@ko3n1g ko3n1g added Skip CICD Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger Skip CICD labels Dec 18, 2024
@ko3n1g ko3n1g merged commit af91e52 into main Dec 18, 2024
25 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/ci/final-status-check branch December 18, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Run CICD Set + un-set to retrigger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants