Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick fixes for 0.6.0rc1 #459

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

terrykong
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 18, 2024
@terrykong terrykong changed the title Terryk/0.6 rc1 cherry picks manual chore: cherry-pick fixes for 0.6.0rc1 Dec 18, 2024
@terrykong terrykong added the Run CICD Set + un-set to retrigger label Dec 18, 2024
@terrykong terrykong enabled auto-merge (rebase) December 18, 2024 20:29
@terrykong terrykong merged commit 6721e72 into r0.6.0 Dec 18, 2024
23 of 29 checks passed
@terrykong terrykong deleted the terryk/0.6-rc1-cherry-picks-manual branch December 18, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Run CICD Set + un-set to retrigger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants