Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use github.sha for build #463

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Dec 19, 2024

What does this PR do ?

${{ github.event.pull_request.head.sha || github.sha }} runs - for PRs - on the source branch instead of merge commit. This is almost never really good, and the cause of the intransparent failure of https://github.com/NVIDIA/NeMo-Aligner/actions/runs/12419036746

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g added the Run CICD Set + un-set to retrigger label Dec 19, 2024
@ko3n1g ko3n1g requested a review from terrykong December 19, 2024 20:05
@github-actions github-actions bot added the CI label Dec 19, 2024
@terrykong terrykong enabled auto-merge December 19, 2024 20:17
@terrykong terrykong disabled auto-merge December 19, 2024 20:18
@ko3n1g ko3n1g enabled auto-merge December 19, 2024 20:20
@ko3n1g ko3n1g added this pull request to the merge queue Dec 19, 2024
@ko3n1g ko3n1g removed this pull request from the merge queue due to a manual request Dec 19, 2024
@ko3n1g ko3n1g merged commit 92233b0 into main Dec 19, 2024
22 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/ci/build-on-merge-commit branch December 19, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Run CICD Set + un-set to retrigger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants