Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stable dockerfile #75

Merged
merged 1 commit into from
Jan 8, 2024
Merged

add stable dockerfile #75

merged 1 commit into from
Jan 8, 2024

Conversation

gshennvm
Copy link
Collaborator

@gshennvm gshennvm commented Jan 8, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

fixes signing issues with #47 and #74

Signed-off-by: Daniel Egert <degert@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
@gshennvm gshennvm requested a review from trias702 January 8, 2024 22:02
Copy link
Collaborator

@trias702 trias702 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gshennvm gshennvm merged commit 2e5b5cf into main Jan 8, 2024
5 checks passed
@gshennvm gshennvm deleted the geshen/dockerfile branch January 8, 2024 22:10
gshennvm added a commit that referenced this pull request Jan 26, 2024
Signed-off-by: Daniel Egert <degert@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Co-authored-by: trias702 <daniel.egert@gmail.com>
rohitrango pushed a commit to rohitrango/NeMo-Aligner that referenced this pull request Jun 25, 2024
Signed-off-by: Daniel Egert <degert@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Co-authored-by: trias702 <daniel.egert@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants