Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to provide prior NeMo 2 ckpt path to convert_nemo1_to_nemo… #11452

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

hemildesai
Copy link
Collaborator

…2 script

This also revamps the sample generation script to add some basic argparse options.

…2 script

Signed-off-by: Hemil Desai <hemild@nvidia.com>
hemildesai and others added 2 commits December 2, 2024 22:15
Signed-off-by: hemildesai <hemildesai@users.noreply.github.com>
Signed-off-by: Hemil Desai <hemild@nvidia.com>
Signed-off-by: Hemil Desai <hemild@nvidia.com>
Copy link
Collaborator

@HuiyingLi HuiyingLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

github-actions bot commented Dec 2, 2024

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:


------------------------------------
Your code has been rated at 10.00/10

Thank you for improving NeMo's documentation!

Copy link
Contributor

github-actions bot commented Dec 2, 2024

beep boop 🤖: 🚨 The following files must be fixed before merge!


Your code was analyzed with PyLint. The following annotations have been identified:


------------------------------------
Your code has been rated at 10.00/10

Thank you for improving NeMo's documentation!

Copy link
Contributor

github-actions bot commented Dec 3, 2024

[🤖]: Hi @hemildesai 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@hemildesai hemildesai merged commit 0e604a1 into main Dec 3, 2024
169 of 170 checks passed
@hemildesai hemildesai deleted the hemil/nemo-convert-from-config branch December 3, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants