Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gated_linear_unit bug #8042

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

Agoniii
Copy link
Contributor

@Agoniii Agoniii commented Dec 18, 2023

What does this PR do ?

Fix the issue when running Llama2 eval or LLama2 SFT.

megatron.core.dist_checkpointing.core.CheckpointingException: Global shape mismatch for loaded ((32, 22016, 4096)) and expected ((32, 11008, 4096)) tensor for key model.decoder.layers.mlp.linear_fc1.weight

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Jenkins CI

To run Jenkins, a NeMo User with write access must comment jenkins on the PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the NLP label Dec 18, 2023
Signed-off-by: Agoniii <815244047@qq.com>
@Agoniii Agoniii force-pushed the xueh/fix_gated_linear_unit branch from 2d63996 to 676264d Compare December 18, 2023 12:20
@cuichenx
Copy link
Collaborator

cuichenx commented Jan 3, 2024

jenkins

@cuichenx cuichenx merged commit d62f6ff into NVIDIA:main Jan 4, 2024
11 checks passed
@cuichenx
Copy link
Collaborator

cuichenx commented Jan 4, 2024

merging this as this is critical to unblock any llama2 workflows

minitu pushed a commit to minitu/NeMo that referenced this pull request Jan 19, 2024
Signed-off-by: Agoniii <815244047@qq.com>
Co-authored-by: Chen Cui <chcui@nvidia.com>
ssh-meister pushed a commit to ssh-meister/NeMo that referenced this pull request Feb 15, 2024
Signed-off-by: Agoniii <815244047@qq.com>
Co-authored-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Sasha Meister <ameister@nvidia.com>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
Signed-off-by: Agoniii <815244047@qq.com>
Co-authored-by: Chen Cui <chcui@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants